mingyen066 commented on code in PR #17442:
URL: https://github.com/apache/kafka/pull/17442#discussion_r1795450502
##########
transaction-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/TransactionLogConfig.java:
##########
@@ -85,7 +85,7 @@ public final class TransactionLogConfig {
public TransactionLogConfig(AbstractConfig config) {
this.config = config;
this.transactionTopicMinISR =
config.getInt(TRANSACTIONS_TOPIC_MIN_ISR_CONFIG);
- this.transactionsLoadBufferSize =
config.getInt(TRANSACTIONS_LOAD_BUFFER_SIZE_CONFIG);
+ this.transactionLoadBufferSize =
config.getInt(TRANSACTIONS_LOAD_BUFFER_SIZE_CONFIG);
Review Comment:
Just align the other variables, as none of them have an `s`. Having only one
variable missing the `s` is error-prone. The other option is to add an `s` to
all the other variables. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
