m1a2st commented on code in PR #17442:
URL: https://github.com/apache/kafka/pull/17442#discussion_r1796289519
##########
transaction-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/TransactionLogConfig.java:
##########
@@ -85,7 +85,7 @@ public final class TransactionLogConfig {
public TransactionLogConfig(AbstractConfig config) {
this.config = config;
this.transactionTopicMinISR =
config.getInt(TRANSACTIONS_TOPIC_MIN_ISR_CONFIG);
- this.transactionsLoadBufferSize =
config.getInt(TRANSACTIONS_LOAD_BUFFER_SIZE_CONFIG);
+ this.transactionLoadBufferSize =
config.getInt(TRANSACTIONS_LOAD_BUFFER_SIZE_CONFIG);
Review Comment:
IMHO, I will let these properties match the CONFIG name is better, thus I
will modify other properties, ie: `transactionTopicMinISR` ->
`transactionsTopicMinISR`, but I didn't know this change is nessary or not.
cc @chia7712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
