chia7712 commented on code in PR #17418:
URL: https://github.com/apache/kafka/pull/17418#discussion_r1796911312
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##########
@@ -358,12 +358,19 @@ private void process(final ShareAcknowledgeAsyncEvent
event) {
* consumer join the share group if it is not part of it yet, or send the
updated subscription if
* it is already a member.
*/
- private void process(final ShareSubscriptionChangeEvent ignored) {
+ private void process(final ShareSubscriptionChangeEvent event) {
if (!requestManagers.shareHeartbeatRequestManager.isPresent()) {
Review Comment:
> Can we fail the event with an exception?
+1, as that's the approach we take with ShareUnsubscribeEvent.
> I think we need to separate the processor for the share consumer.
agree. I assume @AndrewJSchofield has a preferred timing for the refactor,
as he has completed many refactors before :smiley:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
