dajac commented on PR #16686:
URL: https://github.com/apache/kafka/pull/16686#issuecomment-2415966917

   > This is due to the call to `currentThread.interrupt()` inside the 
constructor of `InterruptException`? It seems like a problematic usage. I could 
imagine that the user might call `commitSync` before closing and that would 
cause the interrupt to rethrow as well even with the old implementation? Is 
that right?
   
   @hachikuji I think that's right. My understanding is that in the old 
implementation we try to send the request before we check the interrupt in 
ConsumerNetworkClient.poll(). I suppose that this is why we see members leaving 
correctly with the old implementation in our tests. It is because we send the 
leave group but I suppose that we also throw the interrupt exception afterwards.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to