kirktrue commented on PR #16686: URL: https://github.com/apache/kafka/pull/16686#issuecomment-2421009721
Reading over the comments, some basic tenets have been identified and/or clarified. These tenets are, as best I understand, the following: 1. `ConsumerRebalanceListener` execution must be performed on the application thread 2. `ConsumerRebalanceListener` execution must be complete (successfully or not) before attempting to leave the consumer group 3. Issuing the network request to leave the group must be performed on the background thread 4. The `close()` method should honor the timeout provided by the user, except where it would violate tenet 2 5. The `close()` method should honor the interrupt flag, except where it would violate tenet 2 6. The application thread will not wait for the 'leave group' request to be sent if so doing would violate tenets 4 or 5 Are we in agreement on these? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
