apoorvmittal10 commented on code in PR #17515:
URL: https://github.com/apache/kafka/pull/17515#discussion_r1803219617
##########
core/src/test/java/kafka/test/api/ShareConsumerTest.java:
##########
@@ -536,13 +536,12 @@ public void testExplicitAcknowledgementCommitAsync()
throws InterruptedException
shareConsumer1.acknowledge(secondRecord);
shareConsumer1.commitAsync();
- // Allowing acquisition lock timeout to expire.
- Thread.sleep(20000);
Review Comment:
They might go flaky and we need to have a better way of handling but isn't
the places you suggested, there exists polling on same shareConsumer hence if I
ll remove the thread.sleep and a poll triggers from waitUntilCondition then the
acknowledgement request will be sent, and the record will never time out?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
