ShivsundarR commented on code in PR #17515:
URL: https://github.com/apache/kafka/pull/17515#discussion_r1803239657
##########
core/src/test/java/kafka/test/api/ShareConsumerTest.java:
##########
@@ -536,13 +536,12 @@ public void testExplicitAcknowledgementCommitAsync()
throws InterruptedException
shareConsumer1.acknowledge(secondRecord);
shareConsumer1.commitAsync();
- // Allowing acquisition lock timeout to expire.
- Thread.sleep(20000);
Review Comment:
Yeah right, we might need to handle it differently there as the poll() will
end up acknowledging the record. As they aren't flaky now, we can leave it as
it is I guess. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
