mjsax commented on code in PR #17275:
URL: https://github.com/apache/kafka/pull/17275#discussion_r1803839644
##########
tests/kafkatest/tests/streams/streams_broker_bounce_test.py:
##########
@@ -217,11 +209,6 @@ def collect_results(self, sleep_time_secs):
num_threads=[1, 3],
sleep_time_secs=[120],
metadata_quorum=[quorum.isolated_kraft])
- @matrix(failure_mode=["clean_shutdown", "hard_shutdown", "clean_bounce",
"hard_bounce"],
- broker_type=["leader", "controller"],
- num_threads=[1, 3],
- sleep_time_secs=[120],
- metadata_quorum=[quorum.zk])
Review Comment:
Why are we removing this matrix?
##########
tests/kafkatest/tests/streams/streams_broker_bounce_test.py:
##########
@@ -265,8 +253,8 @@ def test_broker_type_bounce_at_start(self, failure_mode,
broker_type, sleep_time
@cluster(num_nodes=7)
@matrix(failure_mode=["clean_shutdown", "hard_shutdown", "clean_bounce",
"hard_bounce"],
num_failures=[2],
- metadata_quorum=quorum.all_non_upgrade)
- def test_many_brokers_bounce(self, failure_mode, num_failures,
metadata_quorum=quorum.zk):
+ metadata_quorum=[quorum.isolated_kraft])
Review Comment:
as above
##########
tests/kafkatest/tests/streams/streams_application_upgrade_test.py:
##########
@@ -56,9 +55,9 @@ def perform_broker_upgrade(self, to_version):
node.version = KafkaVersion(to_version)
self.kafka.start_node(node)
- @cluster(num_nodes=6)
- @matrix(from_version=smoke_test_versions, bounce_type=["full"])
- def test_app_upgrade(self, from_version, bounce_type):
+ @cluster(num_nodes=9)
Review Comment:
Did we figure this one out?
##########
tests/kafkatest/tests/streams/streams_broker_bounce_test.py:
##########
@@ -243,8 +230,9 @@ def test_broker_type_bounce(self, failure_mode,
broker_type, sleep_time_secs, nu
@cluster(num_nodes=7)
@matrix(failure_mode=["clean_shutdown"],
broker_type=["controller"],
- sleep_time_secs=[0])
- def test_broker_type_bounce_at_start(self, failure_mode, broker_type,
sleep_time_secs):
+ sleep_time_secs=[0],
+ metadata_quorum=[quorum.isolated_kraft])
Review Comment:
I thought we agree to run all KS system test with `combined_kraft` ?
##########
tests/kafkatest/tests/streams/streams_application_upgrade_test.py:
##########
@@ -56,9 +55,9 @@ def perform_broker_upgrade(self, to_version):
node.version = KafkaVersion(to_version)
self.kafka.start_node(node)
- @cluster(num_nodes=6)
- @matrix(from_version=smoke_test_versions, bounce_type=["full"])
- def test_app_upgrade(self, from_version, bounce_type):
+ @cluster(num_nodes=9)
+ @matrix(from_version=smoke_test_versions, bounce_type=["full"],
metadata_quorum=[quorum.combined_kraft])
+ def test_app_upgrade(self, from_version, bounce_type, metadata_quorum):
Review Comment:
So we keep as-is for now, and do a follow up PR to cleanup parameters is we
don't need them or add other options?
##########
tests/kafkatest/tests/streams/streams_broker_bounce_test.py:
##########
@@ -284,8 +272,8 @@ def test_many_brokers_bounce(self, failure_mode,
num_failures, metadata_quorum=q
@cluster(num_nodes=7)
@matrix(failure_mode=["clean_bounce", "hard_bounce"],
num_failures=[3],
- metadata_quorum=quorum.all_non_upgrade)
- def test_all_brokers_bounce(self, failure_mode, num_failures,
metadata_quorum=quorum.zk):
+ metadata_quorum=[quorum.isolated_kraft])
Review Comment:
as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
