bbejeck commented on code in PR #17275:
URL: https://github.com/apache/kafka/pull/17275#discussion_r1809555730
##########
tests/kafkatest/tests/streams/streams_broker_bounce_test.py:
##########
@@ -265,8 +253,8 @@ def test_broker_type_bounce_at_start(self, failure_mode,
broker_type, sleep_time
@cluster(num_nodes=7)
@matrix(failure_mode=["clean_shutdown", "hard_shutdown", "clean_bounce",
"hard_bounce"],
num_failures=[2],
- metadata_quorum=quorum.all_non_upgrade)
- def test_many_brokers_bounce(self, failure_mode, num_failures,
metadata_quorum=quorum.zk):
+ metadata_quorum=[quorum.isolated_kraft])
Review Comment:
Required to indicate to use KRaft for metadata quorum. Failing to do so
without a `@matrix` annotation results in this error as the test will default
to ZK without it.
```File "/opt/kafka-dev/tests/kafkatest/services/kafka/kafka.py", line 541,
in security_config
zk_sasl=self.zk.zk_sasl if self.quorum_info.using_zk else False,
zk_tls=self.zk_client_secure,
AttributeError: 'NoneType' object has no attribute 'zk_sasl'
```
##########
tests/kafkatest/tests/streams/streams_broker_bounce_test.py:
##########
@@ -284,8 +272,8 @@ def test_many_brokers_bounce(self, failure_mode,
num_failures, metadata_quorum=q
@cluster(num_nodes=7)
@matrix(failure_mode=["clean_bounce", "hard_bounce"],
num_failures=[3],
- metadata_quorum=quorum.all_non_upgrade)
- def test_all_brokers_bounce(self, failure_mode, num_failures,
metadata_quorum=quorum.zk):
+ metadata_quorum=[quorum.isolated_kraft])
Review Comment:
Required to indicate to use KRaft for metadata quorum. Failing to do so
without a `@matrix` annotation results in this error as the test will default
to ZK without it.
```File "/opt/kafka-dev/tests/kafkatest/services/kafka/kafka.py", line 541,
in security_config
zk_sasl=self.zk.zk_sasl if self.quorum_info.using_zk else False,
zk_tls=self.zk_client_secure,
AttributeError: 'NoneType' object has no attribute 'zk_sasl'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
