kirktrue commented on code in PR #16899:
URL: https://github.com/apache/kafka/pull/16899#discussion_r1805262867
##########
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java:
##########
@@ -355,6 +355,14 @@ public Map<String, Object>
valuesWithPrefixAllOrNothing(String prefix) {
return nonInternalConfigs;
}
+ protected void clearConfig(String key) {
+ Object value = values.get(key);
+ if (value instanceof Number)
+ values.put(key, 0);
+ else
+ values.remove(key);
+ }
Review Comment:
While I would love to change `GroupRebalanceConfig` (KAFKA-17823) to clean
things up, would it work to update the `GroupRebalanceConfig` constructor for
now?
```java
if (protocolType == ProtocolType.CONSUMER &&
config.getString(ConsumerConfig.GROUP_PROTOCOL_CONFIG).equals(GroupProtocol.CONSUMER.name()))
{
this.sessionTimeoutMs = 0;
} else {
this.sessionTimeoutMs =
config.getInt(CommonClientConfigs.SESSION_TIMEOUT_MS_CONFIG);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
