bbejeck commented on code in PR #17328:
URL: https://github.com/apache/kafka/pull/17328#discussion_r1809553694


##########
tests/kafkatest/tests/streams/streams_smoke_test.py:
##########
@@ -49,8 +49,8 @@ def __init__(self, test_context):
     @cluster(num_nodes=8)
     @matrix(processing_guarantee=['exactly_once_v2', 'at_least_once'],
             crash=[True, False],
-            metadata_quorum=quorum.all_non_upgrade)
-    def test_streams(self, processing_guarantee, crash, 
metadata_quorum=quorum.zk):
+            metadata_quorum=[quorum.combined_kraft])

Review Comment:
   Required to indicate to use KRaft for metadata quorum.  Failing to do so 
without a `@matrix` annotation results in this error as the test will default 
to ZK without it.
   ```File "/opt/kafka-dev/tests/kafkatest/services/kafka/kafka.py", line 541, 
in security_config
       zk_sasl=self.zk.zk_sasl if self.quorum_info.using_zk else False, 
zk_tls=self.zk_client_secure,
   AttributeError: 'NoneType' object has no attribute 'zk_sasl'
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to