kevin-wu24 commented on code in PR #17528:
URL: https://github.com/apache/kafka/pull/17528#discussion_r1806833859
##########
core/src/test/scala/unit/kafka/log/UnifiedLogTest.scala:
##########
@@ -3464,13 +3474,13 @@ class UnifiedLogTest {
new SimpleRecord("c".getBytes)), 5)
- log.updateHighWatermark(2L)
+ log.updateHighWatermark(3L)
Review Comment:
This was the test I was referring to in my above comment. I changed this to
3 to align onto a batch boundary, but I'm not sure about the case if the HWM is
not batch aligned. Originally, the call to `log.fetchOffsetSnapshot` on the
line below returned an `LogOffsetMetadata.offset` of 0 since offset 2 is not
batch aligned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
