showuon commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1812370163
##########
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##########
@@ -3076,72 +3083,59 @@ class PlaintextAdminIntegrationTest extends
BaseAdminIntegrationTest {
@ParameterizedTest
@ValueSource(strings = Array("kraft"))
- @Disabled // To be re-enabled once KAFKA-8779 is resolved
def testIncrementalAlterConfigsForLog4jLogLevels(quorum: String): Unit = {
client = createAdminClient
+ val ancestorLogger = "kafka";
val initialLoggerConfig = describeBrokerLoggers()
- val initialRootLogLevel =
initialLoggerConfig.get(Log4jController.ROOT_LOGGER).value()
- assertEquals(initialRootLogLevel,
initialLoggerConfig.get("kafka.controller.KafkaController").value())
- assertEquals(initialRootLogLevel,
initialLoggerConfig.get("kafka.log.LogCleaner").value())
- assertEquals(initialRootLogLevel,
initialLoggerConfig.get("kafka.server.ReplicaManager").value())
-
- val newRootLogLevel = LogLevelConfig.DEBUG_LOG_LEVEL
- val alterRootLoggerEntry = Seq(
- new AlterConfigOp(new ConfigEntry(Log4jController.ROOT_LOGGER,
newRootLogLevel), AlterConfigOp.OpType.SET)
+ val initialKafkaLogLevel = initialLoggerConfig.get("kafka").value()
+ assertEquals(initialKafkaLogLevel,
initialLoggerConfig.get("kafka.server.ControllerServer").value())
+ assertEquals(initialKafkaLogLevel,
initialLoggerConfig.get("kafka.log.LogCleaner").value())
+ assertEquals(initialKafkaLogLevel,
initialLoggerConfig.get("kafka.server.ReplicaManager").value())
Review Comment:
I see. But I still want to see if we can change the root logger to make sure
we didn't break existing behavior. Maybe we can create one more test for it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
