mimaison commented on code in PR #17373: URL: https://github.com/apache/kafka/pull/17373#discussion_r1813405127
########## README.md: ########## @@ -54,9 +54,9 @@ Follow instructions in https://kafka.apache.org/quickstart ./gradlew clients:test --tests org.apache.kafka.clients.MetadataTest.testTimeToNextUpdate ### Running a particular unit/integration test with log4j output ### -By default, there will be only small number of logs output while testing. You can adjust it by changing the `log4j.properties` file in the module's `src/test/resources` directory. +By default, there will be only small number of logs output while testing. You can adjust it by changing the `log4j2.properties` file in the module's `src/test/resources` directory. -For example, if you want to see more logs for clients project tests, you can modify [the line](https://github.com/apache/kafka/blob/trunk/clients/src/test/resources/log4j.properties#L21) in `clients/src/test/resources/log4j.properties` +For example, if you want to see more logs for clients project tests, you can modify [the line](https://github.com/apache/kafka/blob/trunk/clients/src/test/resources/log4j.properties#L21) in `clients/src/test/resources/log4j2.properties` Review Comment: The link also needs updating (as well as the line number) ########## metadata/src/test/resources/log4j2.properties: ########## @@ -0,0 +1,33 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +name=TestConfig +appenders=console + +appender.console.type=Console +appender.console.name=STDOUT +appender.console.layout.type=PatternLayout +appender.console.layout.pattern=[%d] %p %m (%c:%L)%n + +rootLogger.level=DEBUG +rootLogger.appenderRefs=console +rootLogger.appenderRef.console.ref=STDOUT + +loggers=kafka,zookeeper + +logger.kafka.name=org.apache.kafka +logger.kafka.level=DEBUG + +logger.zookeeper.name=org.apache.zookeeper Review Comment: We probably don't need this zookeeper logger ########## build.gradle: ########## @@ -2596,6 +2626,7 @@ project(':streams') { implementation libs.slf4jApi implementation libs.jacksonAnnotations implementation libs.jacksonDatabind + implementation libs.bndlib Review Comment: I'm not convinced we need that dependency. Also it seems to complain about an annotation so at least we should not need it at runtime, so we should not include it in our distribution package. Currently it's included in the artifact generated by `releaseTarGz`. ########## raft/config/kraft-log4j.properties: ########## @@ -21,4 +21,4 @@ log4j.appender.stderr.layout.ConversionPattern=[%d] %p %m (%c)%n log4j.appender.stderr.Target=System.err log4j.logger.org.apache.kafka.raft=INFO -log4j.logger.org.apache.kafka.snapshot=INFO +log4j.logger.org.apache.kafka.snapshot=INFO Review Comment: Let's keep the newline -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
