adixitconfluent commented on code in PR #17539:
URL: https://github.com/apache/kafka/pull/17539#discussion_r1812784514
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -532,6 +541,8 @@ public List<AcquiredRecords> acquire(
RecordBatch firstBatch =
fetchPartitionData.records.batches().iterator().next();
lock.writeLock().lock();
try {
+ // Update the latest fetch offset metadata for any future queries.
+ this.latestFetchOffsetMetadata = fetchOffsetMetadata;
Review Comment:
we store the last fetched offset's properties in `LogOffsetMetadata` class
like the message offset, file position etc. Hence, naming it
`latestFetchOffsetMetadata` makes more sense than `latestFetchBatchMetadata`.
Wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
