AndrewJSchofield commented on code in PR #17539:
URL: https://github.com/apache/kafka/pull/17539#discussion_r1812833979
##########
core/src/main/java/kafka/server/share/DelayedShareFetch.java:
##########
@@ -204,7 +217,29 @@ Map<TopicIdPartition, FetchRequest.PartitionData>
acquirablePartitions() {
return topicPartitionData;
}
- private void releasePartitionLocks(String groupId, Set<TopicIdPartition>
topicIdPartitions) {
+ private boolean isMinBytesCriteriaSatisfied(Map<TopicIdPartition,
FetchRequest.PartitionData> topicPartitionData) {
Review Comment:
nit: I hesitate to correct your Greek, but the singular of "criteria" is
"criterion". Maybe "isMinBytesSatisfied" would be simpler than worrying about
Greek grammar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
