mimaison commented on PR #17498: URL: https://github.com/apache/kafka/pull/17498#issuecomment-2432538504
Thanks for the updates! I noticed we have a few composite tagged fields containing inner fields. For example `FetchResponse` V12+ has `CurrentLeader` and `SnapshotId`. These inner fields are not rendered. Also in some cases, for example `ProduceResponse` v10, we end up with 2 `_tagged_fields` rows next to each other: <img width="1008" alt="image" src="https://github.com/user-attachments/assets/1785658d-3482-45d6-81b5-d4841457caaf";> I wonder if we could number the tagged fields to uniquely identify them. I understand these are edge cases, and this PR already improves the protocol description significantly. We can address these issues in a follow up PR if you want. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
