AndrewJSchofield commented on PR #17498: URL: https://github.com/apache/kafka/pull/17498#issuecomment-2432623580
> Thanks for the updates! > > I noticed we have a few composite tagged fields containing inner fields. For example `FetchResponse` V12+ has `CurrentLeader` and `SnapshotId`. These inner fields are not rendered. Also in some cases, for example `ProduceResponse` v10, we end up with 2 `_tagged_fields` rows next to each other: <img alt="image" width="1008" src="https://private-user-images.githubusercontent.com/903615/379332398-1785658d-3482-45d6-81b5-d4841457caaf.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mjk2OTcyNTIsIm5iZiI6MTcyOTY5Njk1MiwicGF0aCI6Ii85MDM2MTUvMzc5MzMyMzk4LTE3ODU2NThkLTM0ODItNDVkNi04MWI1LWQ0ODQxNDU3Y2FhZi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQxMDIzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MTAyM1QxNTIyMzJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05ZmMyMjU5NTA3NDBiNGUyMjk0MTM3ZmIxZDRjZjI0NGVjMDk5NGMwNz hjYjNmZmE3MjNiZjM1M2MxNGE0YTdiJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.ef9M3_FGAmy1TPTLrIuMN4Xt_0vOjjJQwNo5XJv4AWs"> I wonder if we could number the tagged fields to uniquely identify them. > > I understand these are edge cases, and this PR already improves the protocol description significantly. We can address these issues in a follow up PR if you want. Ah, I didn't handle inner fields and I think I should. I'll take a look. For the numbering of fields, I think that really the problem is that the fields have hierarchical names and they're currently rendered as flat. I'd prefer to treat that as a follow up PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
