cmccabe commented on code in PR #17502:
URL: https://github.com/apache/kafka/pull/17502#discussion_r1813275083
##########
metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java:
##########
@@ -240,7 +240,7 @@ boolean check() {
/**
* The broker heartbeat manager, or null if this controller is on standby.
*/
- private BrokerHeartbeatManager heartbeatManager;
+ private volatile BrokerHeartbeatManager heartbeatManager;
Review Comment:
As far as I know, it wasn't a TOCTOU previously since all the reads and
writes were done from the main controller thread. But now we added a pathway
directly from the request handler thread pool, so it needs to be volatile.
We should try to run helgrind on Kafka some day...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
