lianetm commented on code in PR #17549:
URL: https://github.com/apache/kafka/pull/17549#discussion_r1821082552
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractMembershipManager.java:
##########
@@ -433,7 +442,7 @@ public void transitionToFatal() {
MemberState previousState = state;
transitionTo(MemberState.FATAL);
log.error("Member {} with epoch {} transitioned to fatal state",
memberIdInfoForLog(), memberEpoch);
Review Comment:
this makes me notice that we can probably remove this `memberIdInfoForLog`
now and simply use `memberId` (It was needed given there could be no member ID,
but that's not the case anymore in this manager)
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractMembershipManager.java:
##########
@@ -622,10 +631,10 @@ public void transitionToSendingLeaveGroup(boolean
dueToExpiredPollTimer) {
/**
* Call all listeners that are registered to get notified when the member
epoch is updated.
- * This also includes the latest member ID in the notification. If the
member fails or leaves
- * the group, this will be invoked with empty epoch and member ID.
+ * This also includes the member ID in the notification. If the member
fails or leaves
+ * the group, this will be invoked with empty epoch.
*/
- void notifyEpochChange(Optional<Integer> epoch, Optional<String> memberId)
{
+ void notifyEpochChange(Optional<Integer> epoch, String memberId) {
stateUpdatesListeners.forEach(stateListener ->
stateListener.onMemberEpochUpdated(epoch, memberId));
Review Comment:
let's update the java doc for this `stateUpdatesListeners` that still refers
to a memberID received from the broker
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
