frankvicky commented on code in PR #17549:
URL: https://github.com/apache/kafka/pull/17549#discussion_r1822185721
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##########
@@ -198,14 +209,14 @@ public void testConsumerHeartbeatRequestValidation() {
// SubscribedTopicNames must be present and empty in the first request
(epoch == 0).
ex = assertThrows(InvalidRequestException.class, () ->
context.consumerGroupHeartbeat(
new ConsumerGroupHeartbeatRequestData()
+ .setMemberId(memberId)
.setGroupId("foo")
.setMemberEpoch(0)
.setRebalanceTimeoutMs(5000)
.setTopicPartitions(Collections.emptyList())));
assertEquals("SubscribedTopicNames must be set in first request.",
ex.getMessage());
- // MemberId must be non-empty in all requests except for the first one
where it
- // could be empty (epoch != 0).
+ // MemberId must be non-empty in all requests
Review Comment:
Yes.
Since we have a similar one in `ConsumerGroupHeartbeatRequestTest`, we could
remove this. 👍🏼
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
