chia7712 commented on code in PR #17615:
URL: https://github.com/apache/kafka/pull/17615#discussion_r1821216823
##########
build.gradle:
##########
@@ -2838,6 +2829,55 @@ project(':streams:streams-scala') {
}
}
+project(':streams:integration-tests') {
+ base {
+ archivesName = "kafka-streams-integration-tests"
+ }
+
+ dependencies {
+ api project(':streams')
+ api project(':clients')
+
+ implementation libs.slf4jApi
+
+ // testCompileOnly prevents streams from exporting a dependency on
test-utils, which would cause a dependency cycle
Review Comment:
Is there a circular dependency?
##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java:
##########
@@ -410,7 +410,8 @@ public void shouldResizeCacheAfterThreadRemovalTimesOut()
throws InterruptedExce
addStreamStateChangeListener(kafkaStreams);
startStreamsAndWaitForRunning(kafkaStreams);
- try (final LogCaptureAppender appender =
LogCaptureAppender.createAndRegister(KafkaStreams.class)) {
+ try (final LogCaptureAppender appender =
LogCaptureAppender.createAndRegister()) {
+ appender.setClassLogger(KafkaStreams.class, Level.INFO);
Review Comment:
Could you please add `log4j.properties` to this module?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
