chia7712 commented on code in PR #17615:
URL: https://github.com/apache/kafka/pull/17615#discussion_r1824224323
##########
build.gradle:
##########
@@ -2848,6 +2833,55 @@ project(':streams:streams-scala') {
}
}
+project(':streams:integration-tests') {
+ apply plugin: 'scala'
+
+ base {
+ archivesName = "kafka-streams-integration-tests"
+ }
+
+ dependencies {
+ api project(':streams')
Review Comment:
we don't have production code, so could you please use `testImplementation`
##########
build.gradle:
##########
@@ -2848,6 +2833,55 @@ project(':streams:streams-scala') {
}
}
+project(':streams:integration-tests') {
+ apply plugin: 'scala'
+
+ base {
+ archivesName = "kafka-streams-integration-tests"
+ }
+
+ dependencies {
+ api project(':streams')
+ api project(':clients')
+
+ implementation libs.slf4jApi
Review Comment:
ditto
##########
build.gradle:
##########
@@ -2848,6 +2833,55 @@ project(':streams:streams-scala') {
}
}
+project(':streams:integration-tests') {
+ apply plugin: 'scala'
+
+ base {
+ archivesName = "kafka-streams-integration-tests"
+ }
+
+ dependencies {
+ api project(':streams')
+ api project(':clients')
Review Comment:
ditto
##########
build.gradle:
##########
@@ -2848,6 +2833,55 @@ project(':streams:streams-scala') {
}
}
+project(':streams:integration-tests') {
+ apply plugin: 'scala'
+
+ base {
+ archivesName = "kafka-streams-integration-tests"
+ }
+
+ dependencies {
+ api project(':streams')
+ api project(':clients')
+
+ implementation libs.slf4jApi
+
+ testImplementation project(':clients').sourceSets.test.output
+ testImplementation project(':group-coordinator')
+ testImplementation project(':server')
+ testImplementation project(':server-common')
+ testImplementation project(':server-common').sourceSets.test.output
+ testImplementation project(':storage')
+ testImplementation project(':streams').sourceSets.test.output
+ testImplementation project(':streams:streams-scala')
+ testImplementation project(':test-common')
+ testImplementation project(':tools')
+ testImplementation project(':transaction-coordinator')
+ testImplementation libs.bcpkix
+ testImplementation libs.hamcrest
+ testImplementation libs.junitJupiter
+ testImplementation libs.junitPlatformSuiteEngine // supports suite test
+ testImplementation libs.mockitoCore
+ testImplementation libs.reload4j
+ testImplementation project(':streams:test-utils')
+
+ testRuntimeOnly runtimeTestLibs
+ }
+
+ tasks.create(name: "copyDependantLibs", type: Copy) {
+ from (configurations.runtimeClasspath) {
+ exclude('kafka-streams*')
+ }
+ into "$buildDir/dependant-libs-${versions.scala}"
+ duplicatesStrategy 'exclude'
+ }
+
+ jar {
+ dependsOn 'copyDependantLibs'
+ }
+
Review Comment:
this module have both java and scala code now, so please use joint
compilation.
```
sourceSets {
// Set java/scala source folders in the `scala` block to enable joint
compilation
main {
java {
srcDirs = []
}
scala {
srcDirs = []
}
}
test {
java {
srcDirs = []
}
scala {
srcDirs = ["src/test/java", "src/test/scala"]
}
}
}
```
##########
build.gradle:
##########
@@ -2848,6 +2833,55 @@ project(':streams:streams-scala') {
}
}
+project(':streams:integration-tests') {
+ apply plugin: 'scala'
+
+ base {
+ archivesName = "kafka-streams-integration-tests"
+ }
+
+ dependencies {
+ api project(':streams')
+ api project(':clients')
+
+ implementation libs.slf4jApi
+
+ testImplementation project(':clients').sourceSets.test.output
+ testImplementation project(':group-coordinator')
+ testImplementation project(':server')
+ testImplementation project(':server-common')
+ testImplementation project(':server-common').sourceSets.test.output
+ testImplementation project(':storage')
+ testImplementation project(':streams').sourceSets.test.output
+ testImplementation project(':streams:streams-scala')
+ testImplementation project(':test-common')
+ testImplementation project(':tools')
+ testImplementation project(':transaction-coordinator')
+ testImplementation libs.bcpkix
+ testImplementation libs.hamcrest
+ testImplementation libs.junitJupiter
+ testImplementation libs.junitPlatformSuiteEngine // supports suite test
+ testImplementation libs.mockitoCore
+ testImplementation libs.reload4j
+ testImplementation project(':streams:test-utils')
+
+ testRuntimeOnly runtimeTestLibs
+ }
+
+ tasks.create(name: "copyDependantLibs", type: Copy) {
Review Comment:
we don't need to expose the runtime jars for this test-only module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
