mimaison commented on code in PR #17620:
URL: https://github.com/apache/kafka/pull/17620#discussion_r1827018579
##########
clients/src/main/java/org/apache/kafka/clients/producer/RoundRobinPartitioner.java:
##########
@@ -68,6 +75,13 @@ private int nextValue(String topic) {
return counter.getAndIncrement();
}
+ @SuppressWarnings("deprecation")
Review Comment:
I don't know if we really need to un-deprecate it. However it would be good
to understand why and document that `partition()` can get called twice for the
same batch. That is a confusing behavior that users surely don't expect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
