adixitconfluent commented on code in PR #17539:
URL: https://github.com/apache/kafka/pull/17539#discussion_r1830395752
##########
core/src/main/java/kafka/server/share/ShareFetchUtils.java:
##########
@@ -64,11 +64,7 @@ static Map<TopicIdPartition,
ShareFetchResponseData.PartitionData> processFetchR
TopicIdPartition topicIdPartition = entry.getKey();
FetchPartitionData fetchPartitionData = entry.getValue();
- SharePartition sharePartition =
sharePartitionManager.sharePartition(shareFetchData.groupId(),
topicIdPartition);
- if (sharePartition == null) {
- log.error("Encountered null share partition for groupId={},
topicIdPartition={}. Skipping it.", shareFetchData.groupId(), topicIdPartition);
- continue;
- }
+ SharePartition sharePartition =
sharePartitions.get(topicIdPartition);
Review Comment:
yes, I think changing the log line to below makes more sense.
```
log.trace("Acquired records: {} for topicIdPartition: {}",
shareAcquiredRecords, topicIdPartition);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
