adixitconfluent commented on code in PR #17539:
URL: https://github.com/apache/kafka/pull/17539#discussion_r1830468964
##########
core/src/main/java/kafka/server/share/DelayedShareFetch.java:
##########
@@ -51,21 +55,26 @@ public class DelayedShareFetch extends DelayedOperation {
private static final Logger log =
LoggerFactory.getLogger(DelayedShareFetch.class);
- private final ShareFetchData shareFetchData;
+ private final ShareFetchData partitionsToComplete;
private final ReplicaManager replicaManager;
- private Map<TopicIdPartition, FetchRequest.PartitionData>
topicPartitionDataFromTryComplete;
+ private Map<TopicIdPartition, FetchRequest.PartitionData>
partitionsAcquired;
+ private Map<TopicIdPartition, LogReadResult> partitionsAlreadyFetched;
private final SharePartitionManager sharePartitionManager;
+ private final Map<TopicIdPartition, SharePartition> sharePartitions;
DelayedShareFetch(
- ShareFetchData shareFetchData,
+ ShareFetchData partitionsToComplete,
ReplicaManager replicaManager,
- SharePartitionManager sharePartitionManager) {
- super(shareFetchData.fetchParams().maxWaitMs, Option.empty());
- this.shareFetchData = shareFetchData;
+ SharePartitionManager sharePartitionManager,
+ Map<TopicIdPartition, SharePartition> sharePartitions) {
+ super(partitionsToComplete.fetchParams().maxWaitMs, Option.empty());
+ this.partitionsToComplete = partitionsToComplete;
this.replicaManager = replicaManager;
- this.topicPartitionDataFromTryComplete = new LinkedHashMap<>();
+ this.partitionsAcquired = new LinkedHashMap<>();
Review Comment:
Similar reason as
[above](https://github.com/apache/kafka/pull/17539#discussion_r1830454251), I
did it for performance efficiency. We are iterating over `partitionsAcquired`
in `releasePartitionLocks`, hence I thought it would be more efficient to use
LinkedHashMap over HashMap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
