ableegoldman commented on code in PR #17702:
URL: https://github.com/apache/kafka/pull/17702#discussion_r1830559435
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsProducer.java:
##########
@@ -240,7 +240,7 @@ private static boolean isRecoverable(final KafkaException
uncaughtException) {
* @throws IllegalStateException if EOS is disabled
* @throws TaskMigratedException
*/
- protected void commitTransaction(final Map<TopicPartition,
OffsetAndMetadata> offsets,
+ public void commitTransaction(final Map<TopicPartition, OffsetAndMetadata>
offsets,
Review Comment:
unrelated to the main fix, just doing some cleanup of the TTD on the side. I
don't see why we can't just make this method public since it's an internal
class anyways -- which was the exact reasoning I saw on the PR which originally
changed it from private to protected anyway. But I can leave this part out if
there are any concerns
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
