mjsax commented on code in PR #17710:
URL: https://github.com/apache/kafka/pull/17710#discussion_r1831957679


##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordQueue.java:
##########
@@ -240,6 +240,7 @@ private void updateHead() {
                         deserialized.topic(), deserialized.partition(), 
deserialized.offset(), timestamp, 
timestampExtractor.getClass().getCanonicalName()
                 );
                 droppedRecordsSensor.record();
+                lastCorruptedRecord = raw;

Review Comment:
   This is the actual fix -- we track the record with invalid ts as "corrupted 
record" instead of dropping it completely. The `CorrecuptedRecrods` allows us 
to update the offset later, but would be dropped by itself and not be processed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to