mjsax commented on code in PR #17710:
URL: https://github.com/apache/kafka/pull/17710#discussion_r1831959021


##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##########
@@ -1451,18 +1492,15 @@ public void 
shouldBeProcessableIfAllPartitionsBuffered() {
 
         assertFalse(task.process(0L));
 
-        final byte[] bytes = ByteBuffer.allocate(4).putInt(1).array();
-
-        task.addRecords(partition1, singleton(new ConsumerRecord<>(topic1, 1, 
0, bytes, bytes)));
+        task.addRecords(partition1, 
singleton(getConsumerRecordWithOffsetAsTimestamp(partition1, 0)));

Review Comment:
   need to change this to avoid a default ts which is negative and would break 
this test (same below)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to