kirktrue commented on code in PR #17670:
URL: https://github.com/apache/kafka/pull/17670#discussion_r1835553656
##########
core/src/test/scala/integration/kafka/server/QuorumTestHarness.scala:
##########
@@ -204,10 +205,19 @@ abstract class QuorumTestHarness extends Logging {
TestInfoUtils.isShareGroupTest(testInfo)
}
- def maybeGroupProtocolSpecified(testInfo: TestInfo): Option[GroupProtocol] =
{
+ def maybeGroupProtocolSpecified(): Option[GroupProtocol] = {
TestInfoUtils.maybeGroupProtocolSpecified(testInfo)
}
+ def groupProtocolFromTestParameters() = {
+ val gp = maybeGroupProtocolSpecified()
+
+ if (gp.isEmpty)
+ throw new IllegalStateException("Please specify the group.protocol
configuration when creating a KafkaConsumer")
Review Comment:
I updated the error message to `Please specify the "groupProtocol" parameter
when writing the test`. I didn't use `groupProtocol=consumer` in the error
message because the value of `groupProtocol` can be `classic` or `consumer`.
PTAL. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
