kirktrue commented on code in PR #17670:
URL: https://github.com/apache/kafka/pull/17670#discussion_r1835554434
##########
core/src/test/scala/integration/kafka/server/FetchRequestTestDowngrade.scala:
##########
@@ -43,8 +43,9 @@ class FetchRequestTestDowngrade extends BaseRequestTest {
)
}
- @Test
- def testTopicIdIsRemovedFromFetcherWhenControllerDowngrades(): Unit = {
+ @ParameterizedTest(name =
TestInfoUtils.TestWithParameterizedQuorumAndGroupProtocolNames)
+
@MethodSource(Array("getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly_ZK_implicit"))
+ def testTopicIdIsRemovedFromFetcherWhenControllerDowngrades(quorum:
String, groupProtocol: String): Unit = {
Review Comment:
There are around 20 integration tests that are effectively Zookeeper-only.
In some cases, nothing in the test explicitly calls that dependency out. I
introduced the `@MethodSource`
`getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly_ZK_implicit()`
which includes the test parameters `quorum=zk` and `groupProtocol=classic`. The
idea is that someone more knowledgeable about the tests would review these and
either a) remove the test, or b) update the test to run against Kraft, if
possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
