frankvicky commented on code in PR #17749:
URL: https://github.com/apache/kafka/pull/17749#discussion_r1836020127
##########
clients/src/main/java/org/apache/kafka/clients/admin/CreateDelegationTokenOptions.java:
##########
@@ -53,12 +53,23 @@ public Optional<KafkaPrincipal> owner() {
return Optional.ofNullable(owner);
}
- public CreateDelegationTokenOptions maxlifeTimeMs(long maxLifeTimeMs) {
- this.maxLifeTimeMs = maxLifeTimeMs;
+ @Deprecated
Review Comment:
I think we should add a javadoc to indication this.
```suggestion
/**
* @deprecated since 4.0 and should not be used any longer.
*/
@Deprecated
```
##########
clients/src/main/java/org/apache/kafka/clients/admin/CreateDelegationTokenOptions.java:
##########
@@ -53,12 +53,23 @@ public Optional<KafkaPrincipal> owner() {
return Optional.ofNullable(owner);
}
- public CreateDelegationTokenOptions maxlifeTimeMs(long maxLifeTimeMs) {
- this.maxLifeTimeMs = maxLifeTimeMs;
+ @Deprecated
+ public CreateDelegationTokenOptions maxlifeTimeMs(long maxLifetimeMs) {
+ this.maxLifetimeMs = maxLifetimeMs;
return this;
}
+ public CreateDelegationTokenOptions maxLifetimeMs(long maxLifetimeMs) {
+ this.maxLifetimeMs = maxLifetimeMs;
+ return this;
+ }
+
+ @Deprecated
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
