frankvicky commented on code in PR #17749:
URL: https://github.com/apache/kafka/pull/17749#discussion_r1836049122
##########
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##########
@@ -3355,6 +3355,7 @@ public DeleteRecordsResult deleteRecords(final
Map<TopicPartition, RecordsToDele
}
@Override
+ @SuppressWarnings("deprecation")
Review Comment:
The reason of adding this suppress annotation is that the method still
invoke the deprecated method ?
If so, we could replace the deprecated method with new one which doesn't not
have typo and we don't need the suppress annotation.
##########
tools/src/main/java/org/apache/kafka/tools/DelegationTokenCommand.java:
##########
@@ -92,6 +92,7 @@ static void execute(String... args) throws Exception {
}
}
+ @SuppressWarnings("deprecation")
Review Comment:
dittp
##########
tools/src/main/java/org/apache/kafka/tools/DelegationTokenCommand.java:
##########
@@ -92,6 +92,7 @@ static void execute(String... args) throws Exception {
}
}
+ @SuppressWarnings("deprecation")
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
