smjn commented on code in PR #17772:
URL: https://github.com/apache/kafka/pull/17772#discussion_r1837860425
##########
share/src/main/java/org/apache/kafka/server/share/persister/DefaultStatePersister.java:
##########
@@ -211,7 +228,8 @@ private ReadShareGroupStateResult readResponsesToResult(
int partition = partitionFuture.getKey();
CompletableFuture<ReadShareGroupStateResponse> future
= partitionFuture.getValue();
try {
- ReadShareGroupStateResponse partitionResponse =
future.get();
+ // already completed because of allOf call in the
caller
+ ReadShareGroupStateResponse partitionResponse =
future.get(0, TimeUnit.MILLISECONDS);
Review Comment:
@apoorvmittal10
`join` will not serve the purpose as it is a blocking call. We would not be
able to return the result to the cller immediately. The way we have
implemented, there is no blocking at all until the final get call is made by
the caller of the `DefaultStatePersister`. Join would block the response to
caller.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
