mumrah commented on code in PR #17772:
URL: https://github.com/apache/kafka/pull/17772#discussion_r1838629919
##########
share/src/test/java/org/apache/kafka/server/share/persister/DefaultStatePersisterTest.java:
##########
@@ -391,7 +396,7 @@ public void testWriteStateSuccess() {
WriteShareGroupStateResult result = null;
try {
- result = resultFuture.get();
+ result = resultFuture.get(100L, TimeUnit.MILLISECONDS);
Review Comment:
I would suggest a higher timeout to avoid flakiness in the event of a GC or
other unexpected pause. If we don't normally expect to actually wait here, we
can set it rather high like 10 seconds or so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
