lianetm commented on code in PR #17777:
URL: https://github.com/apache/kafka/pull/17777#discussion_r1843926122
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractMembershipManager.java:
##########
@@ -851,6 +851,11 @@ void maybeReconcile() {
revokedPartitions
);
+ // Mark partitions as pending revocation to stop fetching from the
partitions (no new
+ // fetches sent out, and no in-flight fetches responses processed).
+ System.out.println("revokedPartitions = " + revokedPartitions);
+ markPendingRevocationToPauseFetching(revokedPartitions);
Review Comment:
forgot to mention, do we still need the other call now that we have this at
the beginning of the reconciliation?
https://github.com/apache/kafka/blob/cc20e7847450d7a3bd5af85f821697e17761cc60/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractMembershipManager.java#L1117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
