FrankYang0529 commented on code in PR #17777:
URL: https://github.com/apache/kafka/pull/17777#discussion_r1843939730
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractMembershipManager.java:
##########
@@ -851,6 +851,11 @@ void maybeReconcile() {
revokedPartitions
);
+ // Mark partitions as pending revocation to stop fetching from the
partitions (no new
+ // fetches sent out, and no in-flight fetches responses processed).
+ System.out.println("revokedPartitions = " + revokedPartitions);
+ markPendingRevocationToPauseFetching(revokedPartitions);
Review Comment:
I think it's better to keep `markPendingRevocationToPauseFetching` in
`AbstractMembershipMember#revokePartitions`, because
`ConsumerMembershipManager#invokeOnPartitionsRevokedOrLostToReleaseAssignment`
also uses the function.
Although it's redundant for consumer heartbeat response path, it's still
required for `ConsumerMembershipManager#signalMemberLeavingGroup` path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
