jolshan commented on code in PR #17698:
URL: https://github.com/apache/kafka/pull/17698#discussion_r1847101927
##########
core/src/main/scala/kafka/log/UnifiedLog.scala:
##########
@@ -629,10 +629,11 @@ class UnifiedLog(@volatile var logStartOffset: Long,
/**
* Return true if the given producer ID has a transaction ongoing.
+ * Note, if the incoming producer epoch is newer than the stored one, the
transaction may have finished.
Review Comment:
nice! happy to see this added :)
I think there is also a chance the epoch is less than the store one? So
maybe in the comment we just say unequal? Or would we fence it before we even
get to this point?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
