jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1847122933
########## clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java: ########## @@ -922,6 +946,103 @@ public void testTransactionManagerEnablesV2() { assertTrue(transactionManager.isTransactionV2Enabled()); } + @Test + public void testTransactionV2AddPartitionAndOffsets() throws InterruptedException { + initializeTransactionManager(Optional.of(transactionalId), true); + doInitTransactions(); + + transactionManager.beginTransaction(); + + Future<RecordMetadata> responseFuture = appendToAccumulator(tp0); + + assertFalse(responseFuture.isDone()); + + prepareProduceResponse(Errors.NONE, producerId, epoch); + assertTrue(transactionManager.transactionContainsPartition(tp0)); Review Comment: just for my understanding, the partition will be added before the produce response returns? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org