CalvinConfluent commented on code in PR #17698:
URL: https://github.com/apache/kafka/pull/17698#discussion_r1857425707
##########
core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala:
##########
@@ -592,7 +586,7 @@ class TransactionCoordinator(txnConfig: TransactionConfig,
val isRetry = retryOnEpochBump || retryOnOverflow
- def generateTxnTransitMetadataForTxnCompletion(nextState:
TransactionState): ApiResult[(Int, TxnTransitMetadata)] = {
+ def generateTxnTransitMetadataForTxnCompletion(nextState:
TransactionState, isEmptyAbort: Boolean): ApiResult[(Int, TxnTransitMetadata)]
= {
Review Comment:
Yes, though it refers to the client trying to abort the transaction with no
partition involved(empty), the name sounds misleading which meaning more like
abort on "Empty" state.
Maybe call it "isNoPartitionAbort"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
