jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1859352623
########## clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java: ########## @@ -172,7 +172,11 @@ private void initializeTransactionManager(Optional<String> transactionalId, bool new ApiVersion() .setApiKey(ApiKeys.PRODUCE.id) .setMinVersion((short) 0) - .setMaxVersion((short) 7)), + .setMaxVersion(transactionV2Enabled ? (short) 12 : (short) 11), Review Comment: nit: should we make this apiKeys.Produce.latestVersion() (was there any reason why the max version was 7?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org