cadonna commented on code in PR #17795:
URL: https://github.com/apache/kafka/pull/17795#discussion_r1858485679
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManagerTest.java:
##########
@@ -347,35 +340,35 @@ void testSuccessfulResponse() {
mockResponse(data);
- ArgumentCaptor<ConsumerGroupHeartbeatResponse> captor =
ArgumentCaptor.forClass(ConsumerGroupHeartbeatResponse.class);
+ ArgumentCaptor<StreamsGroupHeartbeatResponse> captor =
ArgumentCaptor.forClass(StreamsGroupHeartbeatResponse.class);
verify(membershipManager,
times(1)).onHeartbeatSuccess(captor.capture());
- ConsumerGroupHeartbeatResponseData response = captor.getValue().data();
+ StreamsGroupHeartbeatResponseData response = captor.getValue().data();
assertEquals(Errors.NONE.code(), response.errorCode());
assertEquals(TEST_MEMBER_ID, response.memberId());
assertEquals(TEST_MEMBER_EPOCH, response.memberEpoch());
assertEquals(TEST_THROTTLE_TIME_MS, response.throttleTimeMs());
assertEquals(1000, response.heartbeatIntervalMs());
- final List<TopicPartitions> tps =
response.assignment().topicPartitions();
- assertEquals(2, tps.size());
- assertEquals(Set.of(uuid0, uuid1),
tps.stream().map(TopicPartitions::topicId).collect(Collectors.toSet()));
- assertEquals(Collections.singletonList(0), tps.get(0).partitions());
- assertEquals(Collections.singletonList(0), tps.get(1).partitions());
-
- final Assignment targetAssignment =
streamsAssignmentInterface.targetAssignment.get();
- assertEquals(1, targetAssignment.activeTasks.size());
- final TaskId activeTaskId =
targetAssignment.activeTasks.stream().findFirst().get();
- assertEquals(activeTaskId.subtopologyId(), "0");
- assertEquals(activeTaskId.partitionId(), 0);
-
- assertEquals(1, targetAssignment.standbyTasks.size());
- final TaskId standbyTaskId =
targetAssignment.standbyTasks.stream().findFirst().get();
- assertEquals(standbyTaskId.subtopologyId(), "1");
- assertEquals(standbyTaskId.partitionId(), 1);
-
- assertEquals(1, targetAssignment.warmupTasks.size());
- final TaskId warmupTaskId =
targetAssignment.warmupTasks.stream().findFirst().get();
- assertEquals(warmupTaskId.subtopologyId(), "2");
- assertEquals(warmupTaskId.partitionId(), 2);
+// final List<TopicPartitions> tps = response.assign.topicPartitions();
Review Comment:
That is a good question, I need to answer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
