cadonna commented on code in PR #17795:
URL: https://github.com/apache/kafka/pull/17795#discussion_r1858490436
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##########
@@ -1397,23 +1403,59 @@ public void
maybeHandleAssignmentFromStreamsRebalanceProtocol() {
);
// Process assignment from Streams Rebalance Protocol
- final Assignment newAssignment =
streamsAssignmentInterface.targetAssignment.get();
- if
(!newAssignment.equals(streamsAssignmentInterface.reconciledAssignment.get())) {
-
- final Map<TaskId, Set<TopicPartition>>
activeTasksWithPartitions =
-
pairWithTopicPartitions(newAssignment.activeTasks.stream());
- final Map<TaskId, Set<TopicPartition>>
standbyTasksWithPartitions =
-
pairWithTopicPartitions(Stream.concat(newAssignment.standbyTasks.stream(),
newAssignment.warmupTasks.stream()));
+ streamsAssignmentInterface.processStreamsRebalanceEvents();
+ }
+ }
- log.info("Processing new assignment {} from Streams Rebalance
Protocol", newAssignment);
+ private Optional<Exception> onTasksRevoked(final
Set<StreamsAssignmentInterface.TaskId> activeTasksToRevoke) {
Review Comment:
I will consider it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
