FrankYang0529 commented on code in PR #17844:
URL: https://github.com/apache/kafka/pull/17844#discussion_r1858578256


##########
docs/security.html:
##########
@@ -883,10 +883,14 @@ <h3 class="anchor-heading"><a id="security_sasl" 
class="anchor-link"></a><a href
                         <li>Pass the JAAS config file location as JVM 
parameter to each Kafka broker:
                             <pre><code 
class="language-bash">-Djava.security.auth.login.config=/etc/kafka/kafka_server_jaas.conf</code></pre></li>
                         <li>Configure SASL port and SASL mechanisms in 
server.properties as described <a href="#security_sasl_brokerconfig">here</a>. 
For example:
-                            <pre><code 
class="language-text">listeners=SASL_SSL://host.name:port
-security.inter.broker.protocol=SASL_SSL
+                            <pre><code 
class="language-text">listeners=SASL_PLAINTEXT://host.name.1:port.1,CONTROLLER://host.name.2:port.2
+inter.broker.listener.name=SASL_PLAINTEXT
+advertised.listeners=SASL_PLAINTEXT://host.name.1:port.1,CONTROLLER://host.name.2:port.2
+controller.listener.names=CONTROLLER

Review Comment:
   No, I think we can just keep original configs. Reverted it.



##########
docs/security.html:
##########
@@ -909,21 +913,21 @@ <h3 class="anchor-heading"><a id="security_sasl" 
class="anchor-link"></a><a href
                                 as described <a 
href="#security_client_staticjaas">here</a>. Clients use the login section named
                                 <code>KafkaClient</code>. This option allows 
only one user for all client connections from a JVM.</p></li>
                         <li>Configure the following properties in 
producer.properties or consumer.properties:
-                            <pre><code 
class="language-text">security.protocol=SASL_SSL
+                            <pre><code 
class="language-text">security.protocol=SASL_PLAINTEXT

Review Comment:
   Reverted the change. Thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to