AndrewJSchofield commented on PR #17946: URL: https://github.com/apache/kafka/pull/17946#issuecomment-2507389932
The code looks good to me, but I don't think we are ready to merge yet. I've been thinking about the mechanics of delivering this into AK, and this is definitely a change in behaviour of a public interface, which means a KIP is required. It's true that it's preventing an unsafe behaviour which is categorically a good thing, but if someone has an application which is doing this, their code will break following this change. @frankvicky, do you agree? Can you create a KIP to make sure we have community alignment? Without a KIP, we cannot throw the exception, but we can log the message and update the javadoc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
