chia7712 commented on PR #17946: URL: https://github.com/apache/kafka/pull/17946#issuecomment-2528554954
> I think we can get some of the benefit here in spite of the fact that the KIP is too late for AK 4.0. I suggest you change this PR to alter that javadoc to say "This method should not be used" rather than "must not". You can log the error if flush is used in the callback. You cannot throw the KafkaException. What do you think? If we want to avoid introducing behavior changes in version 4.0, adding documentation and logging is an appropriate solution. @frankvicky, could you please file a MINOR issue to address @AndrewJSchofield's comment? In the minor PR, we don't introduce any behavior changes but enrich the documentation and logging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
