chia7712 commented on code in PR #17958:
URL: https://github.com/apache/kafka/pull/17958#discussion_r1866033171
##########
clients/src/main/resources/common/message/ConsumerGroupDescribeResponse.json:
##########
@@ -69,7 +70,9 @@
{ "name": "Assignment", "type": "Assignment", "versions": "0+",
"about": "The current assignment." },
{ "name": "TargetAssignment", "type": "Assignment", "versions":
"0+",
- "about": "The target assignment." }
+ "about": "The target assignment." },
+ { "name": "IsClassic", "type": "bool", "versions": "1+",
"ignorable": true,
+ "about": "True for classic member." }
Review Comment:
> For instance, we could use a int8 with three values: -1, 0, 1. -1 would be
used by default and would mean no provided.
While this approach benefits the Java client, it introduces some drawbacks
for the Java server and RPC layer:
1. Server Implementation Complexity: The server must pass the correct
integer value to `setIsClassic(int)`, which can be easily overlooked by
developers implementing the server.
2. Documentation Requirements: We need to update the documentation to
specify that only 0 and 1 are valid values in RPC version 1 and above. In
contrast, using a boolean with version control would be more readable and
straightforward for this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
