dajac commented on code in PR #17958:
URL: https://github.com/apache/kafka/pull/17958#discussion_r1865966426
##########
clients/src/main/resources/common/message/ConsumerGroupDescribeResponse.json:
##########
@@ -69,7 +70,9 @@
{ "name": "Assignment", "type": "Assignment", "versions": "0+",
"about": "The current assignment." },
{ "name": "TargetAssignment", "type": "Assignment", "versions":
"0+",
- "about": "The target assignment." }
+ "about": "The target assignment." },
+ { "name": "IsClassic", "type": "bool", "versions": "1+",
"ignorable": true,
+ "about": "True for classic member." }
Review Comment:
Using an Optional makes total sense. For the RPC, I was wondering whether we
want to make it more explicit in the schema. For instance, we could use a int8
with three values: -1, 0, 1. -1 would be used by default and would mean no
provided. Relying on the version also works but it may be easy to miss for
people implementing other clients.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
