artemlivshits commented on code in PR #17698:
URL: https://github.com/apache/kafka/pull/17698#discussion_r1866825893
##########
core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala:
##########
@@ -525,6 +558,7 @@ class TransactionCoordinator(txnConfig: TransactionConfig,
producerEpochCopy = txnMetadata.producerEpoch
// PrepareEpochFence has slightly different epoch bumping logic so
don't include it here.
val currentTxnMetadataIsAtLeastTransactionsV2 =
!txnMetadata.pendingState.contains(PrepareEpochFence) &&
txnMetadata.clientTransactionVersion.supportsEpochBump()
+ val incomingEndTxnIsAtLeastTransactionsV2 =
!txnMetadata.pendingState.contains(PrepareEpochFence) &&
clientTransactionVersion.supportsEpochBump()
Review Comment:
Yes, if we use incoming version, we should use it across the board,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
