CalvinConfluent commented on code in PR #17698:
URL: https://github.com/apache/kafka/pull/17698#discussion_r1859529641
##########
clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java:
##########
@@ -3036,12 +3178,10 @@ public void
testEpochUpdateAfterBumpFromEndTxnResponseInV2() throws InterruptedE
doInitTransactions(producerId, epoch);
transactionManager.beginTransaction();
- transactionManager.maybeAddPartition(tp0);
- prepareAddPartitionsToTxnResponse(Errors.NONE, tp0, epoch, producerId);
- runUntil(() -> transactionManager.isPartitionAdded(tp0));
// Append record with initial producer ID and epoch.
Future<RecordMetadata> responseFuture = appendToAccumulator(tp0);
+ transactionManager.maybeAddPartition(tp0);
Review Comment:
It order does not matter, but I think I should move it back.
##########
clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java:
##########
@@ -3036,12 +3178,10 @@ public void
testEpochUpdateAfterBumpFromEndTxnResponseInV2() throws InterruptedE
doInitTransactions(producerId, epoch);
transactionManager.beginTransaction();
- transactionManager.maybeAddPartition(tp0);
- prepareAddPartitionsToTxnResponse(Errors.NONE, tp0, epoch, producerId);
- runUntil(() -> transactionManager.isPartitionAdded(tp0));
// Append record with initial producer ID and epoch.
Future<RecordMetadata> responseFuture = appendToAccumulator(tp0);
+ transactionManager.maybeAddPartition(tp0);
Review Comment:
The order does not matter, but I think I should move it back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
